Bug 120287

Summary:

[GTK] webkitCredentialGetCredential returns a temporary in g_return_val_if_fail

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gustavo, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	pnormand: review+

Description Carlos Garcia Campos 2013-08-26 00:40:12 PDT

webkitCredentialGetCredential() is private function so we shouldn't use g_return macros, but asserts.

Comment 1 Carlos Garcia Campos 2013-08-26 00:41:58 PDT

Created attachment 209621 [details]
Patch

Comment 2 WebKit Commit Bot 2013-08-26 00:43:14 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Carlos Garcia Campos 2013-08-26 00:46:59 PDT

Committed r154589: <http://trac.webkit.org/changeset/154589>