Bug 120287

Summary: [GTK] webkitCredentialGetCredential returns a temporary in g_return_val_if_fail
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Carlos Garcia Campos
Reported 2013-08-26 00:40:12 PDT
webkitCredentialGetCredential() is private function so we shouldn't use g_return macros, but asserts.
Attachments
Patch (1.27 KB, patch)
2013-08-26 00:41 PDT, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-08-26 00:41:58 PDT
Created attachment 209621 [details] Patch
WebKit Commit Bot
Comment 2 2013-08-26 00:43:14 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2013-08-26 00:46:59 PDT
Committed r154589: <http://trac.webkit.org/changeset/154589>
Note You need to log in before you can comment on or make changes to this bug.