| Summary: | ASSERTION FAILED: m_context->document()->documentElement() != m_context in WebCore::SVGLengthContext::determineViewport | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Renata Hodovan <rhodovan.u-szeged> | ||||||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, dino, d-r, fmalita, gyuyoung.kim, koivisto, kondapallykalyan, pdr, rwlbuis, schenney, tgergely.u-szeged, zimmermann | ||||||||||
| Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 116980 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Renata Hodovan
2013-08-26 00:03:08 PDT
Created attachment 209618 [details]
Test case
Created attachment 218946 [details] patch fixes assertion https://chromium.googlesource.com/chromium/blink/+/a7dedf81eb7008276bb6854f0e46465e039788f8 [SVG] Fix root element length values handling. SVGLengthContext::determineViewport() currently asserts that we're not resolving lengths for the topmost element, but there's nothing to prevent such calls. The CL updates determineViewport() to handle root elements geracefully (using their current viewport). It also changes the signature slightly to operate directly on a FloatSize, reducing some of the boiler-plate client code. This patch only merges part ofhttps://chromium.googlesource.com/chromium/blink/+/a7dedf81eb7008276bb6854f0e46465e039788f8. Can you share why? (In reply to comment #3) > This patch only merges part ofhttps://chromium.googlesource.com/chromium/blink/+/a7dedf81eb7008276bb6854f0e46465e039788f8. Can you share why? I did not want to mix up the bugfix and the refactoring because I was not sure that the latter is really required. But I've checked it again and it seems to be real improvement. I'll update the patch. Created attachment 219011 [details]
Updated patch.
Comment on attachment 219011 [details]
Updated patch.
Thanks for bringing this over. If you'll add the tests back to this patch, I'll r+ :)
Created attachment 219422 [details]
Tests added back.
Thanks. And sorry, I created the previous patch after adding but before committing the new files in my local repo, and it seems that git did not respect it.
Attachment 219422 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/svg/custom/svg-length-value-handled-expected.txt', u'LayoutTests/svg/custom/svg-length-value-handled.svg', u'LayoutTests/svg/dom/svg-root-lengths-expected.txt', u'LayoutTests/svg/dom/svg-root-lengths.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/svg/SVGLengthContext.cpp', u'Source/WebCore/svg/SVGLengthContext.h', u'Source/WebCore/svg/graphics/filters/SVGFEImage.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/svg/SVGLengthContext.cpp:193: Declaration has space between type name and * in return value * viewportSize [whitespace/declaration] [3]
ERROR: Source/WebCore/svg/SVGLengthContext.cpp:195: Declaration has space between type name and * in return value * viewportSize [whitespace/declaration] [3]
ERROR: Source/WebCore/svg/SVGLengthContext.cpp:197: Declaration has space between type name and * in return value * sqrtf [whitespace/declaration] [3]
Total errors found: 3 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #8) > Attachment 219422 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/svg/custom/svg-length-value-handled-expected.txt', u'LayoutTests/svg/custom/svg-length-value-handled.svg', u'LayoutTests/svg/dom/svg-root-lengths-expected.txt', u'LayoutTests/svg/dom/svg-root-lengths.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/svg/SVGLengthContext.cpp', u'Source/WebCore/svg/SVGLengthContext.h', u'Source/WebCore/svg/graphics/filters/SVGFEImage.cpp', '--commit-queue']" exit_code: 1 > ERROR: Source/WebCore/svg/SVGLengthContext.cpp:193: Declaration has space between type name and * in return value * viewportSize [whitespace/declaration] [3] > ERROR: Source/WebCore/svg/SVGLengthContext.cpp:195: Declaration has space between type name and * in return value * viewportSize [whitespace/declaration] [3] > ERROR: Source/WebCore/svg/SVGLengthContext.cpp:197: Declaration has space between type name and * in return value * sqrtf [whitespace/declaration] [3] > Total errors found: 3 in 9 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Yes, false positives. Reported in bug 125915. Comment on attachment 219422 [details] Tests added back. Clearing flags on attachment: 219422 Committed r160774: <http://trac.webkit.org/changeset/160774> All reviewed patches have been landed. Closing bug. |