Bug 12028

Summary:

Adapt viewBox parsing to SVGParserUtilities

Product:

WebKit

Reporter:

Rob Buis <rwlbuis>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
First attempt	eric: review+

Rob Buis

Reported 2006-12-29 04:51:08 PST

Adapt the viewBox parsing code to use parseNumber and friends and add a testcase for viewBox parsing.

Attachments
First attempt (51.10 KB, patch) 2006-12-29 04:58 PST, Rob Buis	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2006-12-29 04:58:50 PST

Created attachment 12102 [details] First attempt This patch should do it. Please note that one of the end goals is to remove the old svgpathparser. Cheers, Rob.

Eric Seidel (no email)

Comment 2 2006-12-29 12:05:56 PST

Comment on attachment 12102 [details] First attempt Looks great. You should add some "valid" tests before landing. To make sure that things like " 0 0 30 40 " and "0 0 30,40" work

Rob Buis

Comment 3 2006-12-29 13:02:25 PST

Landed in r18478.

Note You need to log in before you can comment on or make changes to this bug.