Bug 12028 - Adapt viewBox parsing to SVGParserUtilities
Summary: Adapt viewBox parsing to SVGParserUtilities
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2006-12-29 04:51 PST by Rob Buis
Modified: 2006-12-29 13:02 PST (History)
0 users

See Also:

First attempt (51.10 KB, patch)
2006-12-29 04:58 PST, Rob Buis
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2006-12-29 04:51:08 PST
Adapt the viewBox parsing code to use parseNumber and friends and add a testcase for viewBox parsing.
Comment 1 Rob Buis 2006-12-29 04:58:50 PST
Created attachment 12102 [details]
First attempt

This patch should do it. Please note that one of the end goals is to remove the old svgpathparser.

Comment 2 Eric Seidel (no email) 2006-12-29 12:05:56 PST
Comment on attachment 12102 [details]
First attempt

Looks great.

You should add some "valid" tests before landing.  To make sure that things like "   0    0 30 40   " and "0 0 30,40" work
Comment 3 Rob Buis 2006-12-29 13:02:25 PST
Landed in r18478.