Bug 120265

Summary: No need for clearTimers function in Frame
Product: WebKit Reporter: Darin Adler <darin>
Component: Page LoadingAssignee: Darin Adler <darin>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, dbates, ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2013-08-25 01:25:26 PDT
No need for clearTimers function in Frame
Attachments
Patch (3.64 KB, patch)
2013-08-25 01:27 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2014-02-02 22:15 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-08-25 01:27:22 PDT
Created attachment 209577 [details] Patch
Andreas Kling
Comment 2 2013-08-25 02:07:05 PDT
Comment on attachment 209577 [details] Patch Nice.
WebKit Commit Bot
Comment 3 2013-08-25 02:32:26 PDT
Comment on attachment 209577 [details] Patch Clearing flags on attachment: 209577 Committed r154571: <http://trac.webkit.org/changeset/154571>
WebKit Commit Bot
Comment 4 2013-08-25 02:32:28 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 5 2013-08-25 07:21:42 PDT
This broke the internal iOS build in Source/WebCore/page/ios/FrameIOS.mm. Rolled out in r154577. <http://trac.webkit.org/r154577>
Darin Adler
Comment 6 2013-08-25 10:18:23 PDT
Can we upstream the iOS code that depends on this?
Antonio Gomes
Comment 7 2013-08-26 04:47:28 PDT
(In reply to comment #5) > This broke the internal iOS build in Source/WebCore/page/ios/FrameIOS.mm. > > Rolled out in r154577. <http://trac.webkit.org/r154577> Hi. Did you reopen it because Darin is an Apple employee and can supposedly easily build IOS private branch, or is it now WebKit developers' responsibility to maintain it?
Darin Adler
Comment 8 2014-02-02 22:15:09 PST
Created attachment 222961 [details] Patch
Darin Adler
Comment 9 2014-02-02 22:15:58 PST
Oops, forgot about the problem with iOS.
Darin Adler
Comment 10 2017-06-07 09:06:45 PDT
I am not going to bother with this any time soon.
Note You need to log in before you can comment on or make changes to this bug.