| Summary: | Simplify some more Settings access where we have a Frame in reach. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||
| Component: | WebCore Misc. | Assignee: | Andreas Kling <kling> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, dino, d-r, eflews.bot, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kling, kondapallykalyan, ossy, pdr, rego+ews, schenney, simon.fraser, webkit-ews, xan.lopez | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andreas Kling
2013-08-24 16:27:03 PDT
Created attachment 209562 [details]
Patch
Created attachment 209563 [details]
Lander
Comment on attachment 209563 [details] Lander Rejecting attachment 209563 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Versions/A/WebCore Undefined symbols for architecture x86_64: "__ZNK7WebCore12RenderObject5frameEv", referenced from: __ZN7WebCore17RenderSearchField15addSearchResultEv in RenderSearchField.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) ** BUILD FAILED ** The following build commands failed: Ld /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore normal x86_64 (1 failure) Full output: http://webkit-queues.appspot.com/results/1543779 Created attachment 209565 [details]
Lander II: The Landening
Comment on attachment 209565 [details] Lander II: The Landening Attachment 209565 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1555695 Comment on attachment 209565 [details] Lander II: The Landening Attachment 209565 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1542755 Comment on attachment 209565 [details] Lander II: The Landening Attachment 209565 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1543803 Comment on attachment 209565 [details] Lander II: The Landening Attachment 209565 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1544764 Committed r154688: <http://trac.webkit.org/changeset/154688> (In reply to comment #9) > Committed r154688: <http://trac.webkit.org/changeset/154688> Did you really commit intentionally against the red EWS bots and broke the build everywhere? Congratulations! It was so friendly. :-/ I think you should read the contribution rules one more time: http://www.webkit.org/coding/contributing.html "Your change must at least compile on all platforms." I can't see any "except Kling" for this rule ... |