| Summary: | RenderObject::frame() should return a reference. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||||||
| Component: | Layout and Rendering | Assignee: | Andreas Kling <kling> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, darin, eflews.bot, gtk-ews, gyuyoung.kim, kling, philn, rniwa, webkit-ews, xan.lopez | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Andreas Kling
2013-08-24 11:03:49 PDT
Created attachment 209546 [details]
EWS experiment
Comment on attachment 209546 [details] EWS experiment Attachment 209546 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1528959 Created attachment 209547 [details]
EWS experiment 2
Comment on attachment 209547 [details] EWS experiment 2 Attachment 209547 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1561280 Comment on attachment 209547 [details] EWS experiment 2 Attachment 209547 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1555591 Created attachment 209550 [details]
EWS experiment 3
Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1561284 Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1562137 Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1555606 Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1557529 Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1528968 Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1543719 Created attachment 209554 [details]
EWS experiment 4
Created attachment 209558 [details]
EWS experiment 4
Reuploading since EWS was snorkled.
Comment on attachment 209558 [details] EWS experiment 4 Attachment 209558 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1560390 Created attachment 209559 [details]
Patch
Comment on attachment 209559 [details]
Patch
Those local variables of type Frame& worry me a little because they don’t ref the frame. But Frame* was just as bad. We might have to add RefRef!
(In reply to comment #17) > (From update of attachment 209559 [details]) > Those local variables of type Frame& worry me a little because they don’t ref the frame. But Frame* was just as bad. We might have to add RefRef! RefRef! Maybe just Ref? Could be more efficient than RefPtr since it doesn't need to null check before calling ref()/deref(). Comment on attachment 209559 [details] Patch Clearing flags on attachment: 209559 Committed r154554: <http://trac.webkit.org/changeset/154554> All reviewed patches have been landed. Closing bug. |