Bug 12025

Summary:

WebArchive fails to save background images in <tr> tags

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

REOPENED

Severity:

Normal

CC:

bburg, beidson

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
WebArchive layout test (as patch)	none

David Kilzer (:ddkilzer)

Reported 2006-12-28 21:08:00 PST

When a .webarchive file is saved, any background images in <tr> tags are not serialized to the output file.

Attachments
WebArchive layout test (as patch) (4.97 KB, patch) 2006-12-28 21:11 PST, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2006-12-28 21:11:01 PST

Created attachment 12098 [details] WebArchive layout test (as patch) WebArchive layout test formatted as a patch.

Brady Eidson

Comment 2 2008-04-02 23:17:04 PDT

This one is going to be very easy to fix with the new archive setup in WebCore However, I have a question... I find no evidence that <tr>s can officially have background images, standards-wise. Therefore, I'm guessing this is some Mozilla or IE compatibility thing we added. Looking at the HTMLTablePart code, it appears *any* table part can have a background image. Is that correct? If so, shouldn't this patch make sure all table parts get their background images saved?

David Kilzer (:ddkilzer)

Comment 3 2008-04-03 13:25:55 PDT

(In reply to comment #2) > This one is going to be very easy to fix with the new archive setup in WebCore > However, I have a question... I find no evidence that <tr>s can officially > have background images, standards-wise. Therefore, I'm guessing this is some > Mozilla or IE compatibility thing we added. > > Looking at the HTMLTablePart code, it appears *any* table part can have a > background image. Is that correct? > > If so, shouldn't this patch make sure all table parts get their background > images saved? At the time, I think I only tested <tr> tags. If HTMLTablePart supports background images on all parts, then we should archive them.

Brady Eidson

Comment 4 2008-04-03 15:00:44 PDT

A few further points of discussion: -The background attribute isn't officially supported for anything but <body>, I think, so its weird and nonstandard that we support it for any table parts -The background attribute for HTMLTablePart is fed directly into inline style information and handled in a very CSSey fashion. -Therefore, while we could support archiving the resource pointed to by the background attribute for table parts specifically, there's a broader-reaching problem of archiving resources referred to by all inline style. Not saying I don't plan to fix this specific bug, but... the more accurate we get with esoteric subresources (like background images of <tr>s), the more apparent it is that we're ignoring a large class of subresources

Brian Burg

Comment 5 2014-12-14 19:59:28 PST

WAR export isn't supported these days.

Brian Burg

Comment 6 2014-12-14 20:01:11 PST

Oops, thought this was filed as an inspector bug.

Note You need to log in before you can comment on or make changes to this bug.