Summary: | Web Inspector: We should regenerate InspectorBackendCommands.js for Legacy Inspector.json versions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | burg, graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2013-08-23 17:52:02 PDT
Created attachment 209528 [details]
[PATCH] Proposed Fix
- includes the Inspector.json for iOS 6.0.
- includes a script for regenerating the Legacy/6.0/InspectorBackendCommands.js.
- some other tweaks to improve output
FWIW, iOS 6.1 was identical to iOS 6.0. Comment on attachment 209528 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=209528&action=review > Source/WebInspectorUI/ChangeLog:9 > + - Provide a helper script to regenerate the backend commands file for trunk and Versions. We should run this every build eventually. Maybe we should disable the JS command generation in WebCore. (In reply to comment #4) > (From update of attachment 209528 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209528&action=review > > > Source/WebInspectorUI/ChangeLog:9 > > + - Provide a helper script to regenerate the backend commands file for trunk and Versions. > > We should run this every build eventually. Maybe we should disable the JS command generation in WebCore. Good idea. I'd love to do that once we've had all clients switch to the new inspector frontend! It is pretty fast, and if we could make a few changes to only generate the JS file for older inputs. Committed <http://trac.webkit.org/changeset/154651>. Sorry for landing with "OOPs" in the commit message. It did have a reviewer in the ChangeLogs! *** Bug 117843 has been marked as a duplicate of this bug. *** |