Bug 120237

Summary: Optimize FloatIntervalSearchAdapter::collectIfNeeded
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: New BugsAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Bem Jones-Bey
Reported 2013-08-23 14:44:26 PDT
Optimize FloatIntervalSearchAdapter::collectIfNeeded
Attachments
Patch (14.28 KB, patch)
2013-08-23 15:04 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch (14.23 KB, patch)
2013-08-26 13:31 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch (14.23 KB, patch)
2013-08-26 14:03 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-08-23 15:04:10 PDT
Created attachment 209515 [details] Patch Port patches from Blink
Dave Hyatt
Comment 2 2013-08-26 11:11:05 PDT
Comment on attachment 209515 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209515&action=review r=me > Source/WebCore/ChangeLog:20 > + significatly changed by using the outermost float instead of the last Typo. "significantly"
Bem Jones-Bey
Comment 3 2013-08-26 13:31:27 PDT
Created attachment 209673 [details] Patch Update for review comment
WebKit Commit Bot
Comment 4 2013-08-26 13:33:57 PDT
Comment on attachment 209673 [details] Patch Rejecting attachment 209673 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 209673, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Dave Hyatt found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/1584024
Bem Jones-Bey
Comment 5 2013-08-26 14:03:42 PDT
Created attachment 209675 [details] Patch Fix reviewer name
WebKit Commit Bot
Comment 6 2013-08-26 14:34:41 PDT
Comment on attachment 209675 [details] Patch Clearing flags on attachment: 209675 Committed r154641: <http://trac.webkit.org/changeset/154641>
WebKit Commit Bot
Comment 7 2013-08-26 14:34:43 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 8 2013-08-28 20:44:52 PDT
*** Bug 120452 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.