Bug 12018

Summary: Cleanup of CSSRule and its subclasses.
Product: WebKit Reporter: Sam Weinig <sam>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch
none
patch 2 ggaren: review+

Sam Weinig
Reported 2006-12-28 14:30:34 PST
Patch forthcoming.
Attachments
patch (24.76 KB, patch)
2006-12-28 15:05 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
patch 2 (22.39 KB, patch)
2006-12-29 06:33 PST, Sam Weinig 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2006-12-28 15:05:40 PST
Created attachment 12087 [details] patch - Make CSSRule::type() virtual instead of using a member variable. - Make CSSRule::setCssText() virtual and take an ExceptionCode argument to conform to the spec. Subclasses are also stubbed with the method and a FIXME comment urging for their implementation. - Cleanup cssText() implementations. - General style cleanup.
Sam Weinig
Comment 2 2006-12-28 15:50:30 PST
Comment on attachment 12087 [details] patch Removing review flag. Many things are wrong with patch.
Sam Weinig
Comment 3 2006-12-29 06:33:30 PST
Created attachment 12103 [details] patch 2 After a discussion on IRC it became apparen that many parts of the previous patch were misguided. So, I've changed the scope of the patch to just make CSSRule::type() virtual instead of using a member variable and do some general style cleanup.
Geoffrey Garen
Comment 4 2006-12-29 11:17:28 PST
Comment on attachment 12103 [details] patch 2 r=me
Sam Weinig
Comment 5 2006-12-29 11:44:24 PST
Landed in r18476.
Note You need to log in before you can comment on or make changes to this bug.