| Summary: | Cleanup of CSSRule and its subclasses. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 420+ | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.4 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2006-12-28 14:30:34 PST
Created attachment 12087 [details]
patch
- Make CSSRule::type() virtual instead of using a member variable.
- Make CSSRule::setCssText() virtual and take an ExceptionCode argument to conform to the spec. Subclasses are also stubbed with the method and a FIXME comment urging for their implementation.
- Cleanup cssText() implementations.
- General style cleanup.
Comment on attachment 12087 [details]
patch
Removing review flag. Many things are wrong with patch.
Created attachment 12103 [details]
patch 2
After a discussion on IRC it became apparen that many parts of the previous patch were misguided. So, I've changed the scope of the patch to just make CSSRule::type() virtual instead of using a member variable and do some general style cleanup.
Comment on attachment 12103 [details]
patch 2
r=me
|