Bug 12018 - Cleanup of CSSRule and its subclasses.
Summary: Cleanup of CSSRule and its subclasses.
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2006-12-28 14:30 PST by Sam Weinig
Modified: 2006-12-29 11:44 PST (History)
0 users

See Also:

patch (24.76 KB, patch)
2006-12-28 15:05 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
patch 2 (22.39 KB, patch)
2006-12-29 06:33 PST, Sam Weinig
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2006-12-28 14:30:34 PST
Patch forthcoming.
Comment 1 Sam Weinig 2006-12-28 15:05:40 PST
Created attachment 12087 [details]

- Make CSSRule::type() virtual instead of using a member variable.
- Make CSSRule::setCssText() virtual and take an ExceptionCode argument to conform to the spec.  Subclasses are also stubbed with the method and a FIXME comment urging for their implementation.
- Cleanup cssText() implementations.
- General style cleanup.
Comment 2 Sam Weinig 2006-12-28 15:50:30 PST
Comment on attachment 12087 [details]

Removing review flag.  Many things are wrong with patch.
Comment 3 Sam Weinig 2006-12-29 06:33:30 PST
Created attachment 12103 [details]
patch 2

After a discussion on IRC it became apparen that many parts of the previous patch were misguided.  So, I've changed the scope of the patch to just make CSSRule::type() virtual instead of using a member variable and do some general style cleanup.
Comment 4 Geoffrey Garen 2006-12-29 11:17:28 PST
Comment on attachment 12103 [details]
patch 2

Comment 5 Sam Weinig 2006-12-29 11:44:24 PST
Landed in r18476.