Bug 120145

Summary: Another null-deref under WebDragClient::startDrag
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Tim Horton
Reported 2013-08-21 17:54:18 PDT
In http://trac.webkit.org/changeset/153511 I made convertImageToBitmap return null instead of dereferencing the null ShareableBitmap, but missed the place where we dereference the return value, and I missed that because I simultaneously fixed the one reproducible case of getting a null into this method in the first place :( Add the second null-deref. <rdar://problem/14650652>
Attachments
patch (1.50 KB, patch)
2013-08-21 17:55 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-08-21 17:55:51 PDT
Created attachment 209316 [details] patch
Tim Horton
Comment 2 2013-08-21 17:59:08 PDT
http://trac.webkit.org/changeset/154433
Note You need to log in before you can comment on or make changes to this bug.