Bug 120133
| Summary: | Remove support for the hspace/vspace attributes on table | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Pieters (:zcorpan) <zcorpan> |
| Component: | Tables | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, cdumez, karlcow, kling, koivisto, mathias, rniwa, simon.fraser, webkit-bug-importer, webkit.bugzilla, zalan |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=244279 | ||
Simon Pieters (:zcorpan)
WebKit supports vspace and hspace attributes on <table> while IE doesn't and Gecko only does in quirks mode and they are considering dropping that, too.
See https://bugzilla.mozilla.org/show_bug.cgi?id=725646
Compatibility analysis in https://bugzilla.mozilla.org/show_bug.cgi?id=725646#c14 and #c15 (summary: 4 out of top 53,000 sites' front pages have minor visual difference if vspace/hspace on table is dropped)
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=277080
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
*** Bug 167612 has been marked as a duplicate of this bug. ***
Ryosuke Niwa
See https://github.com/whatwg/html/pull/13
Ahmad Saleem
Webkit still support 'hspace' and 'vspace':
https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L330
Chrome / Blink removed it in 2015:
https://src.chromium.org/viewvc/blink?view=revision&revision=190025
Safari also fail following WPT tests:
https://wpt.fyi/results/html/rendering/non-replaced-elements/tables?label=master&label=experimental&aligned&view=subtest&q=table-vspace-hspace
Also Safari 15.6.1 on macOS 12.5.1 render this test case (from Chrome bug - Comment 9) different compared to Chrome Canary 106 and Firefox Nightly 105:
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=2984
Just wanted to share updated test results. Thanks!
Ahmad Saleem
I will work on it later tonight.
Ahmad Saleem
https://github.com/WebKit/WebKit/pull/3573
EWS
Committed 253788@main (6676a3759ed3): <https://commits.webkit.org/253788@main>
Reviewed commits have been landed. Closing PR #3631 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/99150785>