Remove JSObject::propertyIsEnumerable

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Gavin Barraclough]

This method just a wart.  Unnecessary const-casting, unnecessary function call, and less code if we remove.

[Gavin Barraclough]

Created attachment 209290 [details]
Fix

[Sam Weinig]

Comment on attachment 209290 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=209290&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        This method just a wart.

This sentence just a wart.

> Source/JavaScriptCore/ChangeLog:9
> +        Unnecessary const-casting, unnecessary function call, and less code if we remove.

This sentence would be less words if we remove.

> Source/JavaScriptCore/runtime/ObjectPrototype.cpp:188
> +    PropertyDescriptor descriptor;
> +    bool enumerable = thisObject->getOwnPropertyDescriptor(exec, propertyName, descriptor) && descriptor.enumerable();
> +    return JSValue::encode(jsBoolean(enumerable));

This should should have a FIXME saying to use getOwnPropertySlot when it no longer has the global object hack.

[Gavin Barraclough]

Committed revision 154405.