Bug 12011

Summary:

svg/custom/dynamic-svg-document-creation.svg is failing

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rwlbuis

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Fix testcase	mitz: review+

Geoffrey Garen

Reported 2006-12-27 19:39:46 PST

This is the change that broke it: Changed by: rwlbuis Changed at: Thu 28 Dec 2006 11:12:41 Revision: 18440 Changed files: /LayoutTests/ChangeLog /LayoutTests/svg/custom/transform-invalid-expected.txt /LayoutTests/svg/custom/transform-invalid.svg /WebCore/CMakeLists.txt /WebCore/ChangeLog /WebCore/WebCore.xcodeproj/project.pbxproj /WebCore/ksvg2/svg/SVGParserUtilities.cpp /WebCore/ksvg2/svg/SVGParserUtilities.h /WebCore/ksvg2/svg/SVGPathElement.cpp /WebCore/ksvg2/svg/SVGPathElement.h /WebCore/ksvg2/svg/SVGTransformable.cpp /WebCore/ksvg2/svg/svgpathparser.cpp /WebCore/ksvg2/svg/svgpathparser.h Comments: Reviewed by Eric. http://bugs.webkit.org/show_bug.cgi?id=11108 Replace usage of split by proper parsers http://bugs.webkit.org/show_bug.cgi?id=11908 WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes Get rid of split() when parsing transform attribute.

Attachments
Fix testcase (1.09 KB, patch) 2006-12-28 00:56 PST, Rob Buis	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2006-12-28 00:56:01 PST

Created attachment 12079 [details] Fix testcase

mitz

Comment 2 2006-12-28 00:59:12 PST

Comment on attachment 12079 [details] Fix testcase r=me

Rob Buis

Comment 3 2006-12-28 01:06:45 PST

Landed in r18450.

Note You need to log in before you can comment on or make changes to this bug.