Bug 120107

Summary: [mips][arm EABI] Fix P_DFGOperation_EJS call in DFG.
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, fu, ggaren, kilvadyb, oliver, ossy, rgabor, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix P_DFGOperation_EJS call for MIPS and ARM EABI
none
Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format) none

Description Julien Brianceau 2013-08-21 00:51:42 PDT 
EncodedJSValue parameters must be aligned to even registers for MIPS and ARM EABI.

This constraint is not followed in JITCompiler::Call callOperation(P_DFGOperation_EJS operation, GPRReg result, JSValueRegs value, size_t index) implementation.
Comment 1 Julien Brianceau 2013-08-21 00:57:47 PDT 
Created attachment 209255 [details]
Fix P_DFGOperation_EJS call for MIPS and ARM EABI

Please note that I found this issue by reading the code, but I didn't have time to validate it on a MIPS or ARM environment.
Comment 2 Julien Brianceau 2013-08-22 00:43:42 PDT 
Created attachment 209329 [details]
Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format)
Comment 3 Yong Li 2013-08-22 05:14:47 PDT 
Comment on attachment 209329 [details]
Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format)

looks good to me
Comment 4 WebKit Commit Bot 2013-08-22 05:36:51 PDT 
Comment on attachment 209329 [details]
Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format)

Clearing flags on attachment: 209329

Committed r154442: <http://trac.webkit.org/changeset/154442>
Comment 5 WebKit Commit Bot 2013-08-22 05:36:53 PDT 
All reviewed patches have been landed.  Closing bug.