Bug 120098

Summary: [Windows] Enable the New Web Inspector
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Web InspectorAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, bweinstein, graouts, joepeck, timothy, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 120113    
Bug Blocks: 118676    
Attachments:
Description Flags
Patch just copies files around.
bweinstein: review+
Screenshot of New Inspector on Windows
none
Screenshot after enabling CSS_IMAGE_SET none

Description Brent Fulgham 2013-08-20 18:07:17 PDT
Why should Windows be left out?  Time to get access to the new Web Inspector!
Comment 1 Brent Fulgham 2013-08-20 18:07:40 PDT
<rdar://problem/14159549>
Comment 2 Radar WebKit Bug Importer 2013-08-20 18:08:00 PDT
<rdar://problem/14791568>
Comment 3 Brent Fulgham 2013-08-20 18:17:50 PDT
Created attachment 209243 [details]
Patch just copies files around.
Comment 4 Brent Fulgham 2013-08-20 18:19:10 PDT
Comment on attachment 209243 [details]
Patch just copies files around.

The patch looks big and scary, but it's basically just copying files around. Visual Studio is not compact in its representation of things.
Comment 5 Brent Fulgham 2013-08-20 18:23:57 PDT
Created attachment 209244 [details]
Screenshot of New Inspector on Windows
Comment 6 Joseph Pecoraro 2013-08-20 18:26:16 PDT
This looks good to me! I'd prefer someone with Windows experience to look over the Windows project/build related bits.
Comment 7 Joseph Pecoraro 2013-08-20 22:25:27 PDT
Comment on attachment 209243 [details]
Patch just copies files around.

I just want to make sure. As we add new files to WebInspectorUI, will we need to add entries to the vcxproj and vcxproj.filters files? I hope not, that is a burden we would like to avoid. Is there a way for VisualStudio to just include a directory without enumerating all the contents?
Comment 8 Brent Fulgham 2013-08-20 22:58:58 PDT
(In reply to comment #7)
> (From update of attachment 209243 [details])
> I just want to make sure. As we add new files to WebInspectorUI, will we need to add entries to the vcxproj and vcxproj.filters files? I hope not, that is a burden we would like to avoid. Is there a way for VisualStudio to just include a directory without enumerating all the contents?

I'll look into it, but I think it's unlikely.

The project file really only exists to make it easy to find/edit the css/js/html files.  The "build" phase is done purely with scripts/wildcards, so forgetting to add a file in the project will NOT prevent the new code from being integrated and used with the build.
Comment 9 Brent Fulgham 2013-08-21 08:50:29 PDT
This feature assumes that ENABLE(CSS_IMAGE_SET) is true.  For some reason, this was never activated on Windows (even though all the code seems to be in place).
Comment 10 Brent Fulgham 2013-08-21 09:50:04 PDT
Created attachment 209280 [details]
Screenshot after enabling CSS_IMAGE_SET
Comment 11 Brian Weinstein 2013-08-21 10:15:47 PDT
Comment on attachment 209243 [details]
Patch just copies files around.

r=me on code changes, rs=me on project changes.
Comment 12 Brent Fulgham 2013-08-21 10:18:19 PDT
Committed r154395: <http://trac.webkit.org/changeset/154395>