Bug 120081
| Summary: | lint-test-expectations complains about a seemingly-legitimate override | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | dpranke, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=138698 | ||
Tim Horton
platform/mac/TestExpectations has the following pair of lines:
webkit.org/b/60731 ietestcenter/css3/grid/grid-items-003.htm [ ImageOnlyFailure ]
webkit.org/b/60731 [ MountainLion Release ] ietestcenter/css3/grid/grid-items-003.htm [ Pass ImageOnlyFailure ]
This seems like a reasonable override, but lint-test-expectations complains like so:
LayoutTests/platform/mac/TestExpectations:987 More specific entry for ietestcenter/css3/grid/grid-items-003.htm on line LayoutTests/platform/mac/TestExpectations:986 overrides line LayoutTests/platform/mac/TestExpectations:987. ietestcenter/css3/grid/grid-items-003.htm
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dirk Pranke
Two lines in the same file are not allowed to have overlapping sets of modifiers. You would have to change this to something like:
[Lion] .... [ ImageOnlyFailure]
[MountainLion Debug] ... [ ImageOnlyFailure ]
[ML Release] ... [ Pass ImageOnlyFailure ]
At one point fairly early on in the evolution of new-run-webkit-tests, there was logic so that a more specific set of modifiers could legally override a less-specific set of modifiers, but it was deemed that this made things too confusing and hard to maintain. I think the code for this may actually mostly still be in test_expectations.py, but I don't know that you'd want to change it.