Bug 120075

Summary: REGRESSION (r128400): BBC4 website not displaying pictures
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.bbc.co.uk/bbcfour/best-of
Attachments:
Description Flags
Patch oliver: review+

Michael Saboff
Reported 2013-08-20 11:06:15 PDT
Javascript is used to process the image paths shown on http://www.bbc.co.uk/bbcfour/best-of. As of r128400, that processing is not working. It turns out that the array returned by RegExp.match gets reified after PutByVal write are done to the array, thus overwriting the modifications to the array. This is due to the array indexing type being wrong for RegExpMatchesArray objects. Currently it is ArrayWithArrayStorage and should be ArrayWithSlowPutArrayStorage. Patch forthcoming. <rdar://problem/14716775>
Attachments
Patch (4.36 KB, patch)
2013-08-20 11:41 PDT, Michael Saboff 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-08-20 11:41:14 PDT
Created attachment 209211 [details] Patch
Michael Saboff
Comment 2 2013-08-20 11:46:39 PDT
Committed r154346: <http://trac.webkit.org/changeset/154346>
Note You need to log in before you can comment on or make changes to this bug.