Bug 120074

Summary: In RenderTableCell::paintCollapsedBorders() check surrounding cells using physical rather than logical direction
Product: WebKit Reporter: Robert Hogan <robert>
Component: Layout and RenderingAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, robert
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 119759    
Attachments:
Description Flags
Patch none

Robert Hogan
Reported 2013-08-20 10:38:28 PDT
cellAbove(), cellBelow() check the logical rather than the physical direction. This isn't what's needed in paintCollapsedBorders()
Attachments
Patch (5.92 KB, patch)
2013-08-20 10:47 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2013-08-20 10:47:28 PDT
Created attachment 209207 [details] Patch
Dave Hyatt
Comment 2 2013-08-20 11:51:28 PDT
Comment on attachment 209207 [details] Patch This patch looks good, but it does highlight the fact that we need to rename cellBefore/After/Above/Below, since they aren't truly physical. I think we should rename them to: previousCellInRow, nextCellInRow, cellInPreviousRow, cellInNextRow I think that would be more clear than above/below/before/after, especially with how before/after is overloaded to mean "above/below" in writing modes. :)
WebKit Commit Bot
Comment 3 2013-08-21 09:43:58 PDT
Comment on attachment 209207 [details] Patch Clearing flags on attachment: 209207 Committed r154389: <http://trac.webkit.org/changeset/154389>
WebKit Commit Bot
Comment 4 2013-08-21 09:44:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.