Bug 120074

Summary:

In RenderTableCell::paintCollapsedBorders() check surrounding cells using physical rather than logical direction

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

Layout and Rendering

Assignee:

Robert Hogan <robert>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, robert

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

119759

Attachments:

Description	Flags
Patch	none

Description Robert Hogan 2013-08-20 10:38:28 PDT

cellAbove(), cellBelow() check the logical rather than the physical direction. This isn't what's needed in paintCollapsedBorders()

Comment 1 Robert Hogan 2013-08-20 10:47:28 PDT

Created attachment 209207 [details]
Patch

Comment 2 Dave Hyatt 2013-08-20 11:51:28 PDT

Comment on attachment 209207 [details]
Patch

This patch looks good, but it does highlight the fact that we need to rename cellBefore/After/Above/Below, since they aren't truly physical. I think we should rename them to:

previousCellInRow, nextCellInRow, cellInPreviousRow, cellInNextRow

I think that would be more clear than above/below/before/after, especially with how before/after is overloaded to mean "above/below" in writing modes. :)

Comment 3 WebKit Commit Bot 2013-08-21 09:43:58 PDT

Comment on attachment 209207 [details]
Patch

Clearing flags on attachment: 209207

Committed r154389: <http://trac.webkit.org/changeset/154389>

Comment 4 WebKit Commit Bot 2013-08-21 09:44:00 PDT

All reviewed patches have been landed.  Closing bug.