Bug 120067

Summary: Remove getPropertyDescriptor
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: gtk-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix oliver: review+, gtk-ews: commit-queue-

Gavin Barraclough
Reported 2013-08-20 07:20:51 PDT
This is used by lookupGetter/lookupSetter – this can easily bee replaced by getPropertySlot. Since we'll be getting the GetterSetter from the slot in the setter case, rename isGetter() to isAccessor().
Attachments
Fix (6.82 KB, patch)
2013-08-20 07:27 PDT, Gavin Barraclough 		oliver: review+
gtk-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2013-08-20 07:27:44 PDT
Created attachment 209194 [details] Fix
kov's GTK+ EWS bot
Comment 2 2013-08-20 08:27:28 PDT
Comment on attachment 209194 [details] Fix Attachment 209194 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1514595
Oliver Hunt
Comment 3 2013-08-20 09:52:01 PDT
Comment on attachment 209194 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=209194&action=review Fix gtk before landing > Source/JavaScriptCore/ChangeLog:8 > + This is used by lookupGetter/lookupSetter â this can easily bee replaced by getPropertySlot. no unicode!!!
Gavin Barraclough
Comment 4 2013-08-20 10:11:27 PDT
Committed revision 154337.
Note You need to log in before you can comment on or make changes to this bug.