Bug 120060

Summary: [Qt][WK2] Doesn't build without Plugin-process
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: WebKit2Assignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, commit-queue, jturcotte, kbalazs, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jturcotte: review+

Allan Sandfeld Jensen
Reported 2013-08-20 02:40:44 PDT
In Qt we enable netscape-plugin-api on Mac and Windows for WebKit1, but do not enable plugin-process since we do not support plugins on mac and win in WebKit2. This configuration currently does not build.
Attachments
Patch (1.30 KB, patch)
2013-08-20 02:43 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (1.37 KB, patch)
2013-08-20 03:14 PDT, Allan Sandfeld Jensen 		jturcotte: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-08-20 02:43:06 PDT
Created attachment 209176 [details] Patch
Allan Sandfeld Jensen
Comment 2 2013-08-20 03:14:23 PDT
Created attachment 209178 [details] Patch
Jocelyn Turcotte
Comment 3 2013-08-20 03:19:44 PDT
Comment on attachment 209178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209178&action=review > Source/WebKit2/Target.pri:18 > +enable?(netscape_plugin_api):enable?(plugin_architecture_unsupported) { enable?(plugin_architecture_unsupported) doesn't read quite well, but well, a hack is a hack. r=me
Allan Sandfeld Jensen
Comment 4 2013-08-20 03:43:30 PDT
Committed r154321: <http://trac.webkit.org/changeset/154321>
Note You need to log in before you can comment on or make changes to this bug.