Bug 120060

Summary:

[Qt][WK2] Doesn't build without Plugin-process

Product:

WebKit

Reporter:

Allan Sandfeld Jensen <allan.jensen>

Component:

WebKit2

Assignee:

Allan Sandfeld Jensen <allan.jensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, cmarcelo, commit-queue, jturcotte, kbalazs, menard

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	jturcotte: review+

Description Allan Sandfeld Jensen 2013-08-20 02:40:44 PDT

In Qt we enable netscape-plugin-api on Mac and Windows for WebKit1, but do not enable plugin-process since we do not support plugins on mac and win in WebKit2. This configuration currently does not build.

Comment 1 Allan Sandfeld Jensen 2013-08-20 02:43:06 PDT

Created attachment 209176 [details]
Patch

Comment 2 Allan Sandfeld Jensen 2013-08-20 03:14:23 PDT

Created attachment 209178 [details]
Patch

Comment 3 Jocelyn Turcotte 2013-08-20 03:19:44 PDT

Comment on attachment 209178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209178&action=review

> Source/WebKit2/Target.pri:18
> +enable?(netscape_plugin_api):enable?(plugin_architecture_unsupported) {

enable?(plugin_architecture_unsupported) doesn't read quite well, but well, a hack is a hack.

r=me

Comment 4 Allan Sandfeld Jensen 2013-08-20 03:43:30 PDT

Committed r154321: <http://trac.webkit.org/changeset/154321>