Bug 120031

Summary:

isReplacementObscured is wrong when the indicator is clipped by an iframe

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Plug-ins

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, esprehn+autocc, glenn, gordon_sheridan, kondapallykalyan, sfalken, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	simon.fraser: review+

Description Tim Horton 2013-08-19 15:48:48 PDT

RenderEmbeddedObject::isReplacementObscured uses HitTestRequest::IgnoreClipping when hit-testing, causing it to be wrong in light of things like <iframe>.

<rdar://problem/14606819>

Comment 1 Tim Horton 2013-08-19 16:19:37 PDT

Actually, we can't not IgnoreClipping, that breaks lots of the other tests.

Really what we need to do is climb up the document tree and hit-test from the main document, not from the iframe's document.

Comment 2 Tim Horton 2013-08-19 16:19:54 PDT

The intended behavior gets a bit complicated with scrolling.

Comment 3 Tim Horton 2013-08-19 19:19:47 PDT

Created attachment 209149 [details]
patch

a little bit concerned about the LayoutRect->IntRect bit.

Comment 4 Tim Horton 2013-08-21 14:02:55 PDT

http://trac.webkit.org/changeset/154412