Bug 120017

Summary: Remove NodeRenderingTraversal::ParentDetails
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, glenn, kangil.han, kling, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2013-08-19 10:50:45 PDT
Remove this oddly factored type that is used to optionally collect some data during ComposedShadowTreeWalker parent traversal.
Attachments
patch (21.83 KB, patch)
2013-08-19 12:41 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-08-19 12:41:57 PDT
Created attachment 209109 [details] patch
Andreas Kling
Comment 2 2013-08-19 22:24:15 PDT
Comment on attachment 209109 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=209109&action=review r=me > Source/WebCore/css/StyleResolver.cpp:-834 > - if (state.distributedToInsertionPoint()) { > - if (Element* parent = element->parentElement()) { > - if (RenderStyle* styleOfShadowHost = parent->renderStyle()) > - state.style()->setUserModify(styleOfShadowHost->userModify()); > - } > - } Heh, I was here just the other day trying to figure out how to reach this code.
Antti Koivisto
Comment 3 2013-08-20 08:27:13 PDT
https://trac.webkit.org/r154327
Note You need to log in before you can comment on or make changes to this bug.