Bug 120002

Summary: [CSS Masking] Add -webkit-mask-source-type shorthand property
Product: WebKit Reporter: Andrei Parvu <parvu>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, krit, macpherson, menard, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andrei Parvu
Reported 2013-08-19 01:20:16 PDT
We want to add the -webkit-mask-source-type property to the -webkit-mask shorthand property.
Attachments
Patch (7.35 KB, patch)
2013-08-19 01:37 PDT, Andrei Parvu 		no flags
DetailsFormatted DiffDiff
Patch (7.22 KB, patch)
2013-08-28 05:11 PDT, Andrei Parvu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrei Parvu
Comment 1 2013-08-19 01:37:41 PDT
Created attachment 209066 [details] Patch
Dirk Schulze
Comment 2 2013-08-28 03:52:11 PDT
Comment on attachment 209066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209066&action=review Looks good to me. Just some snippets. > Source/WebCore/css/CSSParser.cpp:2847 > + const CSSPropertyID properties[] = { CSSPropertyWebkitMaskImage, CSSPropertyWebkitMaskRepeat, CSSPropertyWebkitMaskSourceType, Put this right after MaskImage to match the spec please. > Source/WebCore/css/StylePropertyShorthand.cpp:441 > + CSSPropertyWebkitMaskSourceType Put this right after MaskImage to match the spec please. > Source/WebCore/css/StylePropertyShorthand.cpp:888 > + map.set(CSSPropertyWebkitMaskSourceType, mask); Ditto.
Andrei Parvu
Comment 3 2013-08-28 05:11:41 PDT
Created attachment 209866 [details] Patch
Dirk Schulze
Comment 4 2013-08-28 06:47:24 PDT
Comment on attachment 209866 [details] Patch r=me
WebKit Commit Bot
Comment 5 2013-08-28 07:09:45 PDT
Comment on attachment 209866 [details] Patch Clearing flags on attachment: 209866 Committed r154742: <http://trac.webkit.org/changeset/154742>
WebKit Commit Bot
Comment 6 2013-08-28 07:09:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.