Bug 120001

Summary:

Clean up StyleElement

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, d-r, esprehn+autocc, fmalita, kangil.han, kling, pdr, schenney

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+

Description Antti Koivisto 2013-08-19 01:10:10 PDT

It has some issues.

Comment 1 Antti Koivisto 2013-08-19 01:28:54 PDT

Created attachment 209065 [details]
patch

Comment 2 Andreas Kling 2013-08-19 01:45:54 PDT

Comment on attachment 209065 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209065&action=review

r=me

(Wow, process -> createSheetFromTextContents.)

> Source/WebCore/dom/StyleElement.cpp:119
> +    if  (type.isEmpty())

Two spaces!?

> Source/WebCore/dom/StyleElement.cpp:147
> +    MediaQueryEvaluator screenEval("screen", true);
> +    MediaQueryEvaluator printEval("print", true);

Something, something, ASCIILiteral.

Comment 3 Andreas Kling 2013-08-19 01:46:13 PDT

StyleElement is still a terrible name.

Comment 4 Antti Koivisto 2013-08-19 01:55:37 PDT

http://trac.webkit.org/changeset/154268

Comment 5 Antti Koivisto 2013-08-19 01:56:13 PDT

Yeah an(In reply to comment #3)
> StyleElement is still a terrible name.

Yeah and it should be used as a member, not inherited from.