Bug 119994

Summary: DFG new Array() inlining could get confused about global objects
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: New BugsAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, buildbot, ggaren, mark.lam, mhahnenberg, msaboff, oliver, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion none

Filip Pizlo
Reported 2013-08-18 23:22:16 PDT
DFG new Array() inlining could get confused about global objects
Attachments
Patch (4.22 KB, patch)
2013-08-18 23:23 PDT, Filip Pizlo 		ggaren: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (890.33 KB, application/zip)
2013-08-19 02:08 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-08-18 23:23:43 PDT
Created attachment 209056 [details] Patch
Build Bot
Comment 2 2013-08-19 02:08:50 PDT
Comment on attachment 209056 [details] Patch Attachment 209056 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1510437 New failing tests: fast/js/dfg-cross-global-object-new-array.html
Build Bot
Comment 3 2013-08-19 02:08:52 PDT
Created attachment 209068 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Geoffrey Garen
Comment 4 2013-08-19 09:36:39 PDT
Comment on attachment 209056 [details] Patch r=me
Filip Pizlo
Comment 5 2013-08-19 15:39:30 PDT
Landed in http://trac.webkit.org/changeset/154304
Note You need to log in before you can comment on or make changes to this bug.