Bug 119991

Summary: change usage of calculateUTCOffset()/calculateDSTOffset to calculateLocalTimeOffset
Product: WebKit Reporter: Santosh Mahto <santosh.ma>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Santosh Mahto
Reported 2013-08-18 21:04:50 PDT
calculateUTCOffset()/calculateDSTOffset these two function has been made static in changelist http://trac.webkit.org/changeset/150833 Using these function in other file is wrong and will give compile time error. Instead calculateLocalTimeOffset should be used.
Attachments
Patch (3.24 KB, patch)
2013-08-18 21:08 PDT, Santosh Mahto 		no flags
DetailsFormatted DiffDiff
Patch (3.25 KB, patch)
2013-08-18 21:56 PDT, Santosh Mahto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Santosh Mahto
Comment 1 2013-08-18 21:08:59 PDT
Created attachment 209047 [details] Patch
Santosh Mahto
Comment 2 2013-08-18 21:56:19 PDT
Created attachment 209052 [details] Patch
Darin Adler
Comment 3 2013-08-18 23:01:45 PDT
Comment on attachment 209052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209052&action=review > Source/WebCore/ChangeLog:7 > + Resolving code error. What kind of code error? I don’t understand the reason behind this change. Is this more elegant? More correct? Both? If more correct, was there a test that was failing?
Darin Adler
Comment 4 2013-08-18 23:02:16 PDT
Comment on attachment 209052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209052&action=review >> Source/WebCore/ChangeLog:7 >> + Resolving code error. > > What kind of code error? I don’t understand the reason behind this change. Is this more elegant? More correct? Both? If more correct, was there a test that was failing? Oh, I see, you mean this resolves a build failure? Got it.
Santosh Mahto
Comment 5 2013-08-18 23:16:18 PDT
(In reply to comment #4) > (From update of attachment 209052 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209052&action=review > > >> Source/WebCore/ChangeLog:7 > >> + Resolving code error. > > > > What kind of code error? I don’t understand the reason behind this change. Is this more elegant? More correct? Both? If more correct, was there a test that was failing? > > Oh, I see, you mean this resolves a build failure? Got it. Right, Build will fail when input type date/time/month is enabled.
WebKit Commit Bot
Comment 6 2013-08-19 23:34:39 PDT
Comment on attachment 209052 [details] Patch Clearing flags on attachment: 209052 Committed r154315: <http://trac.webkit.org/changeset/154315>
WebKit Commit Bot
Comment 7 2013-08-19 23:34:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.