| Summary: | Incorrect serialization of quotation marks in XML attributes. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Une Bévue <yt.dev> | ||||||
| Component: | XML | Assignee: | Alexey Proskuryakov <ap> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Major | CC: | ap | ||||||
| Priority: | P2 | ||||||||
| Version: | 420+ | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.4 | ||||||||
| URL: | http://www.yvon-thoraval.com/Canvas/menu.html | ||||||||
| Attachments: |
|
||||||||
Created attachment 12068 [details] test case The problem is that XSLTProcessor re-parses the stylesheet (evil!), while serializer handles quotation marks incorrectly. Here is a workaround: <xsl:value-of select="concat('javascript:setPage(%22',link,'%22);')"/> See also: bug 11947. Created attachment 12110 [details]
proposed fix
Comment on attachment 12110 [details]
proposed fix
+ document.getElementById("result").textContent += ": " + (new XMLSerializer()).serializeToString(document.getElementsByTagName('div')[1]);
Doesn't work so well with the initial text in result (I guess originally it was just FAIL)
The patch looks very straightforward, so assuming it doesn't affect any existing tests, r=me.
Committed revision 18484. (In reply to comment #3) > Doesn't work so well with the initial text in result (I guess originally it was > just FAIL) Oops, indeed. Fixed. |
seems to be due to this XPath syntax : <a> <xsl:attribute name="href"> <xsl:value-of select="concat('javascript:setPage("',link,'");')"/> </xsl:attribute> <xsl:value-of select="label"/> </a> notice exactly same syntax works within Firefox 2 and Opera 9.1