Bug 11998

Summary: Incorrect serialization of quotation marks in XML attributes.
Product: WebKit Reporter: Une Bévue <yt.dev>
Component: XMLAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Major CC: ap
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.yvon-thoraval.com/Canvas/menu.html
Attachments:
Description Flags
test case
none
proposed fix mitz: review+

Une Bévue
Reported 2006-12-27 08:15:10 PST
seems to be due to this XPath syntax : <a> <xsl:attribute name="href"> <xsl:value-of select="concat('javascript:setPage(&quot;',link,'&quot;);')"/> </xsl:attribute> <xsl:value-of select="label"/> </a> notice exactly same syntax works within Firefox 2 and Opera 9.1
Attachments
test case (328 bytes, application/xhtml+xml)
2006-12-27 11:40 PST, Alexey Proskuryakov 		no flags
Details
proposed fix (5.65 KB, patch)
2006-12-29 11:22 PST, Alexey Proskuryakov 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2006-12-27 11:40:25 PST
Created attachment 12068 [details] test case The problem is that XSLTProcessor re-parses the stylesheet (evil!), while serializer handles quotation marks incorrectly. Here is a workaround: <xsl:value-of select="concat('javascript:setPage(%22',link,'%22);')"/> See also: bug 11947.
Alexey Proskuryakov
Comment 2 2006-12-29 11:22:30 PST
Created attachment 12110 [details] proposed fix
mitz
Comment 3 2006-12-29 15:32:38 PST
Comment on attachment 12110 [details] proposed fix + document.getElementById("result").textContent += ": " + (new XMLSerializer()).serializeToString(document.getElementsByTagName('div')[1]); Doesn't work so well with the initial text in result (I guess originally it was just FAIL) The patch looks very straightforward, so assuming it doesn't affect any existing tests, r=me.
Alexey Proskuryakov
Comment 4 2006-12-30 00:54:10 PST
Committed revision 18484. (In reply to comment #3) > Doesn't work so well with the initial text in result (I guess originally it was > just FAIL) Oops, indeed. Fixed.
Note You need to log in before you can comment on or make changes to this bug.