Bug 119933

Summary: [Qt] Fix tst_QObjectBridge::connectAndDisconnect() fail
Product: WebKit Reporter: Arunprasad Rajkumar <arurajku>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, ararunprasad, commit-queue, hausmann, jturcotte, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Arunprasad Rajkumar
Reported 2013-08-16 22:13:35 PDT
FAIL! : tst_QObjectBridge::connectAndDisconnect() Compared values are not the same Actual (ret): TypeError: undefined is not a function (evaluating '(function() { }).connect()') Expected (QLatin1String("TypeError: 'undefined' is not a function (evaluating '(function() { }).connect()')")): TypeError: 'undefined' is not a function (evaluating '(function() { }).connect()') Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp(1575)] The issue is due to wrong exception string comparison. Calling undefined method on a object will raise TypeError: undefined is not a function ..., undefined is not inside single quote(').
Attachments
Patch (2.78 KB, patch)
2013-08-16 22:22 PDT, Arunprasad Rajkumar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arunprasad Rajkumar
Comment 1 2013-08-16 22:22:38 PDT
Created attachment 208977 [details] Patch
WebKit Commit Bot
Comment 2 2013-08-19 03:59:01 PDT
Comment on attachment 208977 [details] Patch Clearing flags on attachment: 208977 Committed r154273: <http://trac.webkit.org/changeset/154273>
WebKit Commit Bot
Comment 3 2013-08-19 03:59:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.