Bug 11993

Summary:

REGRESSION(r18320): Web Inspector scroll bars not drawn

Product:

WebKit

Reporter:

Matt Lilek <dev+webkit>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, mrowe

Priority:

Keywords:

InRadar, Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
attempted patch	none
better patch	timothy: review+

Matt Lilek

Reported 2006-12-27 00:57:14 PST

The Javascript error changes in r18320 caused the web inspector's scroll bars to not draw and spew DOM Exception 12 errors in the console. From what I can tell, this was caused by AppleVerticalScrollbar's computeTrackLength method sometimes returning NaN which totally throws off all the calculations based on that and it eventually trys to set NaN as the scroll bar height in the _setObjectLength method (which WebKit didn't care about before the change). My patch overrides the _setObjectLength method and checks if length is a number before setting it which fixes it (on Tiger at least, don't know about what changes have been made to this on Leopard, though I doubt this breaks anything).

Attachments
attempted patch (1.50 KB, patch) 2006-12-27 00:58 PST, Matt Lilek	no flags	Details Formatted Diff Diff
better patch (2.45 KB, patch) 2006-12-27 09:04 PST, Matt Lilek	timothy: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Matt Lilek

Comment 1 2006-12-27 00:58:38 PST

Created attachment 12054 [details] attempted patch

Matt Lilek

Comment 2 2006-12-27 01:42:17 PST

This fix would probably be better off in inspector.js with a note about why its there wouldn't it? I'll leave it up for comments on the logic and upload a new patch in the morning..

Mark Rowe (bdash)

Comment 3 2006-12-27 02:42:49 PST

Matt, can you file a bug in radar at http://bugreporter.apple.com/ mentioning the breakage that this covers so that it can be tracked internally by Apple?

Matt Lilek

Comment 4 2006-12-27 08:35:21 PST

Filed as radar 4901491

Matt Lilek

Comment 5 2006-12-27 09:04:49 PST

Created attachment 12061 [details] better patch

Sam Weinig

Comment 6 2006-12-27 16:02:31 PST

Landed in r18444.

Note You need to log in before you can comment on or make changes to this bug.