Bug 119923

Summary:

RenderNamedFlowThread should not create NodeRenderingContext objects

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Layout and Rendering

Assignee:

Mihai Maerean <mmaerean>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achicu, buildbot, commit-queue, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, kling, koivisto, kondapallykalyan, mihnea, rego+ews, rniwa, WebkitBugTracker, webkit-ews, xan.lopez

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Ryosuke Niwa

Reported 2013-08-16 20:02:38 PDT

Consider merging https://chromium.googlesource.com/chromium/blink/+/949d7d7e7b8685454742a55cf0ca912bb9a7b177 RenderNamedFlowThread is using NodeRenderingContext to get the original parent renderer, but should just be using NodeRenderingTraversal::parent instead (which is what NodeRenderingContext does internally anyway).

Attachments
Patch (2.67 KB, patch) 2013-08-22 05:10 PDT, Andrei Bucur	no flags	Details Formatted Diff Diff
Patch (2.60 KB, patch) 2013-08-22 06:16 PDT, Andrei Bucur	no flags	Details Formatted Diff Diff
Patch (2.77 KB, patch) 2013-08-22 07:07 PDT, Andrei Bucur	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andrei Bucur

Comment 1 2013-08-22 05:10:10 PDT

Created attachment 209350 [details] Patch

Build Bot

Comment 2 2013-08-22 05:14:23 PDT

Comment on attachment 209350 [details] Patch Attachment 209350 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1545097

Antti Koivisto

Comment 3 2013-08-22 05:14:58 PDT

Comment on attachment 209350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209350&action=review > Source/WebCore/rendering/RenderNamedFlowThread.cpp:486 > + NodeRenderingTraversal::ParentDetails parentDetails; I killed ParentDetails so this is not going to work. The equivalent code is likely to be simple though.

Antti Koivisto

Comment 4 2013-08-22 05:16:52 PDT

Or you can just leave this to be for now. I'm going to remove NodeRenderingContext.

Andrei Bucur

Comment 5 2013-08-22 06:16:03 PDT

Created attachment 209358 [details] Patch

Early Warning System Bot

Comment 6 2013-08-22 06:29:23 PDT

Comment on attachment 209358 [details] Patch Attachment 209358 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1525634

EFL EWS Bot

Comment 7 2013-08-22 06:34:34 PDT

Comment on attachment 209358 [details] Patch Attachment 209358 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1384980