Bug 119923

Summary: RenderNamedFlowThread should not create NodeRenderingContext objects
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Mihai Maerean <mmaerean>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, buildbot, commit-queue, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, kling, koivisto, kondapallykalyan, mihnea, rego+ews, rniwa, WebkitBugTracker, webkit-ews, xan.lopez
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Ryosuke Niwa 2013-08-16 20:02:38 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/949d7d7e7b8685454742a55cf0ca912bb9a7b177

RenderNamedFlowThread is using NodeRenderingContext to get the original
parent renderer, but should just be using NodeRenderingTraversal::parent
instead (which is what NodeRenderingContext does internally anyway).
Comment 1 Andrei Bucur 2013-08-22 05:10:10 PDT
Created attachment 209350 [details]
Patch
Comment 2 Build Bot 2013-08-22 05:14:23 PDT
Comment on attachment 209350 [details]
Patch

Attachment 209350 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1545097
Comment 3 Antti Koivisto 2013-08-22 05:14:58 PDT
Comment on attachment 209350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209350&action=review

> Source/WebCore/rendering/RenderNamedFlowThread.cpp:486
> +    NodeRenderingTraversal::ParentDetails parentDetails;

I killed ParentDetails so this is not going to work. The equivalent code is likely to be simple though.
Comment 4 Antti Koivisto 2013-08-22 05:16:52 PDT
Or you can just leave this to be for now. I'm going to remove NodeRenderingContext.
Comment 5 Andrei Bucur 2013-08-22 06:16:03 PDT
Created attachment 209358 [details]
Patch
Comment 6 Early Warning System Bot 2013-08-22 06:29:23 PDT
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1525634
Comment 7 EFL EWS Bot 2013-08-22 06:34:34 PDT
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1384980
Comment 8 Early Warning System Bot 2013-08-22 06:34:43 PDT
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1426086
Comment 9 kov's GTK+ EWS bot 2013-08-22 06:41:29 PDT
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1538089
Comment 10 Build Bot 2013-08-22 06:45:29 PDT
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1549088
Comment 11 EFL EWS Bot 2013-08-22 06:52:22 PDT
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1380555
Comment 12 Build Bot 2013-08-22 06:58:35 PDT
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1538091
Comment 13 Andrei Bucur 2013-08-22 07:07:50 PDT
Created attachment 209362 [details]
Patch
Comment 14 Antti Koivisto 2013-08-22 08:01:16 PDT
Comment on attachment 209362 [details]
Patch

r=me
Comment 15 WebKit Commit Bot 2013-08-22 08:27:30 PDT
Comment on attachment 209362 [details]
Patch

Clearing flags on attachment: 209362

Committed r154447: <http://trac.webkit.org/changeset/154447>
Comment 16 WebKit Commit Bot 2013-08-22 08:27:34 PDT
All reviewed patches have been landed.  Closing bug.