Bug 119910

Summary: [Windows] Update RenderMediaControls for new API
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch eric.carlson: review+

Brent Fulgham
Reported 2013-08-16 13:20:25 PDT
The RenderMediaControls::paintMediaControlsPart and RenderMediaControls::adjustMediaSliderThumbSize implementations need to be updated to match the new WebKitSystemInterface API for drawing rendering controls.
Attachments
Patch (10.16 KB, patch)
2013-08-16 14:05 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (10.30 KB, patch)
2013-08-16 14:26 PDT, Brent Fulgham 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-08-16 14:05:38 PDT
Created attachment 208955 [details] Patch
Eric Carlson
Comment 2 2013-08-16 14:17:38 PDT
Comment on attachment 208955 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208955&action=review > Source/WebCore/rendering/RenderMediaControls.cpp:57 > +#if HAVE(AVCF_LEGIBLE_OUTPUT) // i.e., the new media controls > +#define wkHitTestMediaUIPart(part, bounds, point) WKHitTestMediaUIPart(part, bounds, point) > +#define wkMeasureMediaUIPart(part, bounds, naturalSize) WKMeasureMediaUIPart(part, bounds, naturalSize) > +#define wkDrawMediaUIPart(part, context, rect, state) WKDrawMediaUIPart(part, context, rect, state) > +#define wkDrawMediaSliderTrack(context, rect, timeLoaded, currentTime, duration, state) WKDrawMediaSliderTrack(context, rect, timeLoaded, currentTime, duration, state) > +#else > +// This is needed until WebKitSystemInterface is updated on the build machines > +#define wkHitTestMediaUIPart(part, bounds, point) WKHitTestMediaUIPart(part, WKMediaControllerThemeQuickTime, bounds, point) > +#define wkMeasureMediaUIPart(part, bounds, naturalSize) WKMeasureMediaUIPart(part, WKMediaControllerThemeQuickTime, bounds, naturalSize) > +#define wkDrawMediaUIPart(part, context, rect, state) WKDrawMediaUIPart(part, WKMediaControllerThemeQuickTime, context, rect, state) > +#define wkDrawMediaSliderTrack(context, rect, timeLoaded, currentTime, duration, state) WKDrawMediaSliderTrack(WKMediaControllerThemeQuickTime, context, rect, timeLoaded, currentTime, duration, state) > +#endif This might be slightly cleaner as inline functions instead of #defines.
Brent Fulgham
Comment 3 2013-08-16 14:26:24 PDT
Created attachment 208960 [details] Patch
Eric Carlson
Comment 4 2013-08-16 14:42:00 PDT
Comment on attachment 208960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208960&action=review Thank you! > Source/WebCore/rendering/RenderMediaControls.cpp:48 > +#if HAVE(AVCF_LEGIBLE_OUTPUT) // i.e., the new media controls The comment isn't necessary, here or in the other the functions.
Brent Fulgham
Comment 5 2013-08-16 14:44:30 PDT
Committed r154205: <http://trac.webkit.org/changeset/154205>
Note You need to log in before you can comment on or make changes to this bug.