| Summary: | DFG should optimize typedArray.byteLength | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2013-08-16 13:03:39 PDT
Created attachment 208949 [details]
the patch
Attachment 208949 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/regress/Int16Array-bubble-sort-with-byteLength-expected.txt', u'LayoutTests/fast/js/regress/Int16Array-bubble-sort-with-byteLength.html', u'LayoutTests/fast/js/regress/Int8Array-load-with-byteLength-expected.txt', u'LayoutTests/fast/js/regress/Int8Array-load-with-byteLength.html', u'LayoutTests/fast/js/regress/script-tests/Int16Array-bubble-sort-with-byteLength.js', u'LayoutTests/fast/js/regress/script-tests/Int8Array-load-with-byteLength.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/SpeculatedType.cpp', u'Source/JavaScriptCore/bytecode/SpeculatedType.h', u'Source/JavaScriptCore/dfg/DFGArrayMode.cpp', u'Source/JavaScriptCore/dfg/DFGArrayMode.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGGraph.h', u'Source/JavaScriptCore/runtime/TypedArrayType.h']" exit_code: 1
Source/JavaScriptCore/dfg/DFGArrayMode.cpp:495: Extra space between return and Array [whitespace/declaration] [3]
Total errors found: 1 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 208949 [details]
the patch
r=me, fix the style error
(In reply to comment #3) > (From update of attachment 208949 [details]) > r=me, fix the style error Thanks, fixed. Landed in http://trac.webkit.org/changeset/154218 |