Bug 11990

Summary: Split out PDFDocument logic into Image subclass
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: PlatformAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 5971    
Attachments:
Description Flags
patch to actually do the split oliver: review+

Eric Seidel (no email)
Reported 2006-12-26 23:55:33 PST
Split out PDFDocument logic into Image subclass This is all in preparation for adding SVGImage.
Attachments
patch to actually do the split (50.24 KB, patch)
2006-12-27 00:37 PST, Eric Seidel (no email) 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2006-12-27 00:37:56 PST
Created attachment 12053 [details] patch to actually do the split This one is for real. I've run the layout tests (and added some -- already landed). I've surfed with this a bit. It's possible this could affect performance, but I don't have any good way of testing that. Ideally hyatt should look at this.
Oliver Hunt
Comment 2 2006-12-27 01:00:52 PST
Comment on attachment 12053 [details] patch to actually do the split looks good, can you delay landing for a day or so?
Eric Seidel (no email)
Comment 3 2006-12-27 01:22:21 PST
Ideally hyatt should at least glance at this patch as well.
Sam Weinig
Comment 4 2006-12-28 11:27:55 PST
Landed in r18446.
Note You need to log in before you can comment on or make changes to this bug.