Bug 119878

Summary: Text Selection on flex and grid box items does not work as expected
Product: WebKit Reporter: Pravin D <pravind>
Component: Layout and RenderingAssignee: Ahmad Saleem <ahmad.saleem792>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, bdakin, commit-queue, dino, esprehn+autocc, glenn, hyatt, joepeck, kondapallykalyan, leviw, mitz, ntim, rniwa, simon.fraser, sudarshan.cp, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
TestCase
none
Patch beidson: review-, buildbot: commit-queue-

Pravin D
Reported 2013-08-15 23:49:00 PDT
Created attachment 208884 [details] TestCase Consider a Flex box having 2 or more children with text(div or span) and the children are laid out horizontally (flex-direction: row). When the content of the 1st child is selected the selction background width excompasses the entire body's width rather than being restricted to the boundries of the flex child.
Attachments
TestCase (767 bytes, text/html)
2013-08-15 23:49 PDT, Pravin D 		no flags
Details
Patch (4.09 KB, patch)
2013-08-16 00:05 PDT, Pravin D 		beidson: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pravin D
Comment 1 2013-08-16 00:05:49 PDT
Created attachment 208885 [details] Patch
Antti Koivisto
Comment 2 2013-08-16 00:38:39 PDT
Comment on attachment 208885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208885&action=review > Source/WebCore/rendering/RenderBlock.cpp:3513 > + if (parent() && parent()->isFlexibleBox()) > + return true; Looks suspicious. This function tests the current element not the parent everywhere else. Hyatt should probably take a look.
Build Bot
Comment 3 2013-08-26 14:18:15 PDT
Comment on attachment 208885 [details] Patch Attachment 208885 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1590037
Brady Eidson
Comment 4 2016-05-24 22:02:33 PDT
Comment on attachment 208885 [details] Patch Assuming that patches for review since 2013 are stale, r-
Ahmad Saleem
Comment 5 2022-09-17 07:25:15 PDT
https://github.com/WebKit/WebKit/pull/4441
EWS
Comment 6 2022-09-17 20:43:47 PDT
Committed 254602@main (48936aafec37): <https://commits.webkit.org/254602@main> Reviewed commits have been landed. Closing PR #4441 and removing active labels.
Radar WebKit Bug Importer
Comment 7 2022-09-17 20:44:17 PDT
<rdar://problem/100080307>
Ahmad Saleem
Comment 8 2022-09-17 23:46:31 PDT
*** Bug 200251 has been marked as a duplicate of this bug. ***
Ahmad Saleem
Comment 9 2023-02-24 15:04:16 PST
*** Bug 128966 has been marked as a duplicate of this bug. ***
Ahmad Saleem
Comment 10 2023-04-20 20:38:29 PDT
*** Bug 241074 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.