Bug 119877

Summary:

DocumentLoader should be finished after convertMainResourceLoadToDownload

Product:

WebKit

Reporter:

Mary Wu <mawu>

Component:

Page Loading

Assignee:

Mary Wu <mawu>

Status:

NEW ---

Severity:

Normal

CC:

ap, beidson, commit-queue, japhet

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	beidson: review-

Description Mary Wu 2013-08-15 22:56:15 PDT

After convertMainResourceLoadToDownload(), we should wrap up current documentLoader. But if mainResource is cachedResource, mainResourceLoader doesn't exist, ResourceLoader::didFail() won't be hit, so the following DocumentLoader() dataReceived() will still cause the page loading. We add cancelMainResourceLoad() to make sure current page load finished gracefully.

Comment 1 Mary Wu 2013-08-15 23:03:22 PDT

Created attachment 208882 [details]
patch

Comment 2 Darin Adler 2013-08-15 23:22:45 PDT

Comment on attachment 208882 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208882&action=review

> Source/WebCore/ChangeLog:13
> +        No new tests (OOPS!).

Why no regression test? Can we make one?

Comment 3 Brady Eidson 2016-05-24 22:02:28 PDT

Comment on attachment 208882 [details]
patch

Assuming that patches for review since 2013 are stale, r-