Bug 119808

Summary: FloatingObject m_paginationStrut should be LayoutUnit
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: Layout and RenderingAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Bem Jones-Bey
Reported 2013-08-14 11:35:39 PDT
It is a vertical offset, and it will be much clearer if the type is correct.
Attachments
Patch (3.99 KB, patch)
2014-02-05 19:51 PST, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.93 KB, patch)
2014-02-07 10:20 PST, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2014-02-05 19:51:42 PST
Created attachment 223293 [details] Patch
Andreas Kling
Comment 2 2014-02-07 01:42:23 PST
Comment on attachment 223293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223293&action=review r=me > Source/WebCore/ChangeLog:13 > + Also, stop copying the originatingLine in FloatingObject::unsafeClone > + because that allows a FloatingObject to point to a line for a renderer > + that it doesn't belong to. I would do this in a separate change.
Bem Jones-Bey
Comment 3 2014-02-07 10:19:15 PST
(In reply to comment #2) > (From update of attachment 223293 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223293&action=review > > r=me > > > Source/WebCore/ChangeLog:13 > > + Also, stop copying the originatingLine in FloatingObject::unsafeClone > > + because that allows a FloatingObject to point to a line for a renderer > > + that it doesn't belong to. > > I would do this in a separate change. Thanks! I'll pull that out into a different patch.
Bem Jones-Bey
Comment 4 2014-02-07 10:20:13 PST
Created attachment 223465 [details] Patch for landing
WebKit Commit Bot
Comment 5 2014-02-07 10:33:04 PST
Comment on attachment 223465 [details] Patch for landing Clearing flags on attachment: 223465 Committed r163631: <http://trac.webkit.org/changeset/163631>
WebKit Commit Bot
Comment 6 2014-02-07 10:33:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.