Summary: | FloatingObject m_paginationStrut should be LayoutUnit | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||
Component: | Layout and Rendering | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Bem Jones-Bey
2013-08-14 11:35:39 PDT
Created attachment 223293 [details]
Patch
Comment on attachment 223293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223293&action=review r=me > Source/WebCore/ChangeLog:13 > + Also, stop copying the originatingLine in FloatingObject::unsafeClone > + because that allows a FloatingObject to point to a line for a renderer > + that it doesn't belong to. I would do this in a separate change. (In reply to comment #2) > (From update of attachment 223293 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223293&action=review > > r=me > > > Source/WebCore/ChangeLog:13 > > + Also, stop copying the originatingLine in FloatingObject::unsafeClone > > + because that allows a FloatingObject to point to a line for a renderer > > + that it doesn't belong to. > > I would do this in a separate change. Thanks! I'll pull that out into a different patch. Created attachment 223465 [details]
Patch for landing
Comment on attachment 223465 [details] Patch for landing Clearing flags on attachment: 223465 Committed r163631: <http://trac.webkit.org/changeset/163631> All reviewed patches have been landed. Closing bug. |