Summary: | [CSS Grid Layout] Fix grid position resolution | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
Component: | CSS | Assignee: | Sergio Villar Senin <svillar> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, hyatt, jchaffraix, kling, kondapallykalyan, mrobinson, svillar, tony | ||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 119552 | ||||||
Bug Blocks: | 60731, 119756 | ||||||
Attachments: |
|
Description
Sergio Villar Senin
2013-08-14 09:01:22 PDT
Created attachment 209342 [details]
Patch
The final patch is not a direct merge of the three patches from Blink. I removed some stuff (like tests with span and negative indexes) that will be included in future patches (like in the one for 119756). Comment on attachment 209342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209342&action=review > Source/WebCore/ChangeLog:16 > + resolveGridPositionsFormStyle() so we can use it for the grid size Typo, resolveGridPositions_From_Style. > Source/WebCore/rendering/RenderGrid.cpp:768 > + ASSERT(position.integerPosition()); This is a well-placed assert. I was worried about negative values here. Committed r154731: <http://trac.webkit.org/changeset/154731> |