| Summary: | ANGLE doesn't build with bison 3.0 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Allan Sandfeld Jensen <allan.jensen> | ||||||
| Component: | ANGLE | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abrhm, achristensen, commit-queue, dino, hugo.lima, kondapallykalyan, rakuco, vestbo, zan, zherczeg | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Allan Sandfeld Jensen
2013-08-14 07:42:48 PDT
Qt bug tracked as https://bugreports.qt-project.org/browse/QTBUG-32913 Created attachment 208725 [details]
Patch
Created attachment 208731 [details]
Patch
Just fix the parser file to be compatible with bison 3
For the record, carewolf has also submitted this upstream: <https://code.google.com/p/angleproject/issues/detail?id=462>. Looks good to me. I tried this on Mac, and it works with Bison 2.3. This is suggested as a patch upstream at https://code.google.com/p/angleproject/issues/detail?id=462 so hopefully we'll merge this change in with a future ANGLE update anyway. By the way, this would change the generated files a little, but there are no functional changes and we're trying to remove them from the repository anyways, so don't worry about that. Comment on attachment 208731 [details] Patch Clearing flags on attachment: 208731 Committed r154109: <http://trac.webkit.org/changeset/154109> All reviewed patches have been landed. Closing bug. |