Bug 119798

Summary: ANGLE doesn't build with bison 3.0
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: ANGLEAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abrhm, achristensen, commit-queue, dino, hugo.lima, kondapallykalyan, rakuco, vestbo, zan, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Allan Sandfeld Jensen
Reported 2013-08-14 07:42:48 PDT
When using bison 3.0 we have problems building ANGLE. I believe the easiest solution is to stop generating our own files and use those pregenerated in WebKit.
Attachments
Patch (2.44 KB, patch)
2013-08-14 08:04 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (1.85 KB, patch)
2013-08-14 08:43 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-08-14 07:44:33 PDT
Qt bug tracked as https://bugreports.qt-project.org/browse/QTBUG-32913
Allan Sandfeld Jensen
Comment 2 2013-08-14 08:04:07 PDT
Created attachment 208725 [details] Patch
Allan Sandfeld Jensen
Comment 3 2013-08-14 08:43:29 PDT
Created attachment 208731 [details] Patch Just fix the parser file to be compatible with bison 3
Raphael Kubo da Costa (:rakuco)
Comment 4 2013-08-15 04:27:43 PDT
For the record, carewolf has also submitted this upstream: <https://code.google.com/p/angleproject/issues/detail?id=462>.
Alex Christensen
Comment 5 2013-08-15 10:20:21 PDT
Looks good to me. I tried this on Mac, and it works with Bison 2.3. This is suggested as a patch upstream at https://code.google.com/p/angleproject/issues/detail?id=462 so hopefully we'll merge this change in with a future ANGLE update anyway.
Alex Christensen
Comment 6 2013-08-15 10:37:12 PDT
By the way, this would change the generated files a little, but there are no functional changes and we're trying to remove them from the repository anyways, so don't worry about that.
WebKit Commit Bot
Comment 7 2013-08-15 10:58:34 PDT
Comment on attachment 208731 [details] Patch Clearing flags on attachment: 208731 Committed r154109: <http://trac.webkit.org/changeset/154109>
WebKit Commit Bot
Comment 8 2013-08-15 10:58:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.