Summary: | Add Canvas protocol observer | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | Web Inspector | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | anonymous, graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dean Jackson
2013-08-13 17:16:58 PDT
Created attachment 208693 [details]
Patch
Comment on attachment 208693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208693&action=review r=me, with 1 comment > Source/WebInspectorUI/UserInterface/Main.js:41 > + InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver); InspectorBackend.registerCanvasDispatcher did not exist in iOS 6. iOS 6 devices load the UserInterface/Legacy/6.0/InspectorBackendCommands.js file instead of the UserInterface/InspectorBackendCommands.js in LoadInspectorBackendCommands.js. So the lack of that function existing will mean that this would be an uncaught exception. You should do this at the bottom like the LayerTreeDispatcher. if (InspectorBackend.registerCanvasDispatcher) InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver); Committed r154034: <http://trac.webkit.org/changeset/154034> |