Bug 119778

Summary: Add Canvas protocol observer
Product: WebKit Reporter: Dean Jackson <dino>
Component: Web InspectorAssignee: Dean Jackson <dino>
Severity: Normal CC: anonymous, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch joepeck: review+

Description Dean Jackson 2013-08-13 17:16:58 PDT
Now that we're enabling Canvas profiling, we need a canvas observer to receive the events sent from the backend.
Comment 1 Radar WebKit Bug Importer 2013-08-13 17:17:13 PDT
Comment 2 Dean Jackson 2013-08-13 17:25:21 PDT
Created attachment 208693 [details]
Comment 3 Joseph Pecoraro 2013-08-13 17:36:02 PDT
Comment on attachment 208693 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=208693&action=review

r=me, with 1 comment

> Source/WebInspectorUI/UserInterface/Main.js:41
> +    InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver);

InspectorBackend.registerCanvasDispatcher did not exist in iOS 6.

iOS 6 devices load the UserInterface/Legacy/6.0/InspectorBackendCommands.js file instead of the UserInterface/InspectorBackendCommands.js in LoadInspectorBackendCommands.js. So the lack of that function existing will mean that this would be an uncaught exception.

You should do this at the bottom like the LayerTreeDispatcher.

    if (InspectorBackend.registerCanvasDispatcher)
        InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver);
Comment 4 Dean Jackson 2013-08-13 18:03:34 PDT
Committed r154034: <http://trac.webkit.org/changeset/154034>