Bug 119743

Summary: [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, andersca, cdumez, cmarcelo, commit-queue, gtk-ews, gustavo, gyuyoung.kim, menard, mrobinson, rakuco, rego+ews, sam, simon.fraser, svillar, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103377    
Attachments:
Description Flags
Patch
gtk-ews: commit-queue-
Updated patch
none
Another update andersca: review+

Description Carlos Garcia Campos 2013-08-13 06:30:31 PDT 
This is required for the javascript injection and isolated worlds API. See https://lists.webkit.org/pipermail/webkit-gtk/2013-August/001535.html.
Comment 1 Carlos Garcia Campos 2013-08-13 06:44:27 PDT 
Created attachment 208624 [details]
Patch
Comment 2 WebKit Commit Bot 2013-08-13 06:46:20 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 kov's GTK+ EWS bot 2013-08-13 07:44:15 PDT 
Comment on attachment 208624 [details]
Patch

Attachment 208624 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1452440
Comment 4 Carlos Garcia Campos 2013-08-13 08:06:40 PDT 
Created attachment 208634 [details]
Updated patch

I forgot to git add some new files
Comment 5 Carlos Garcia Campos 2013-08-13 09:05:39 PDT 
Created attachment 208638 [details]
Another update

Sorry, I forgot to git add two more files.
Comment 6 Sergio Villar Senin 2013-08-13 09:14:51 PDT 
Comment on attachment 208638 [details]
Another update

View in context: https://bugs.webkit.org/attachment.cgi?id=208638&action=review

Changes (informally) look awesome to me

> Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt:1064
> +webkit_frame_get_javascript_global_context

nit: should we have these properly sorted?

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:305
> +        kWKBundlePageLoaderClientCurrentVersion,

wow this probably deserved a separate fix :), good catch
Comment 7 Gustavo Noronha (kov) 2013-08-14 16:07:07 PDT 
Comment on attachment 208638 [details]
Another update

View in context: https://bugs.webkit.org/attachment.cgi?id=208638&action=review

LGTM, r=me, just need to get a wk2 owner to approve, I guess.

>> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:305
>> +        kWKBundlePageLoaderClientCurrentVersion,
> 
> wow this probably deserved a separate fix :), good catch

Indeed, r=me for landing this separately!
Comment 8 Carlos Garcia Campos 2013-08-22 23:29:09 PDT 
(In reply to comment #7)
> (From update of attachment 208638 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208638&action=review
> 
> LGTM, r=me, just need to get a wk2 owner to approve, I guess.
> 
> >> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:305
> >> +        kWKBundlePageLoaderClientCurrentVersion,
> > 
> > wow this probably deserved a separate fix :), good catch
> 
> Indeed, r=me for landing this separately!

Fixed in http://trac.webkit.org/changeset/154474
Comment 9 Anders Carlsson 2013-08-23 05:51:04 PDT 
Comment on attachment 208638 [details]
Another update

View in context: https://bugs.webkit.org/attachment.cgi?id=208638&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:74
> +    DEFINE_STATIC_LOCAL(WebFrameMap, map, ());

Can use NeverDestroyed here!
Comment 10 Carlos Garcia Campos 2013-08-24 01:43:46 PDT 
Committed r154540: <http://trac.webkit.org/changeset/154540>
Comment 12 Zan Dobersek 2013-08-25 12:09:38 PDT 
(In reply to comment #11)
> This has caused 6 unit tests to fail:
> http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29/builds/11911/steps/run-api-tests/logs/stdio

Fix is up for review in bug #120268.