Summary: | Simplify RadioNodeList's anonymous indexed getter | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, ggaren, kling, koivisto, kondapallykalyan, oliver | ||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-08-12 20:57:53 PDT
Created attachment 208608 [details]
Patch
Comment on attachment 208608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208608&action=review > Source/WebCore/ChangeLog:12 > + This change has strictly no impact on the generated bindings code > + but it simplifies the IDL. Doesn't IsIndex cause INDEX_SIZE_ERR to be thrown when the index is negative? (In reply to comment #2) > (From update of attachment 208608 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208608&action=review > > > Source/WebCore/ChangeLog:12 > > + This change has strictly no impact on the generated bindings code > > + but it simplifies the IDL. > > Doesn't IsIndex cause INDEX_SIZE_ERR to be thrown when the index is negative? In theory, yes but not for anonymous indexed getters. As I said in the Changelog, the generated code is *exactly* the same. Also note that throwing an INDEX_SIZE_ERR for negative values in indexed getter would not be according to specification. Comment on attachment 208608 [details] Patch Clearing flags on attachment: 208608 Committed r154003: <http://trac.webkit.org/changeset/154003> All reviewed patches have been landed. Closing bug. |