Bug 119712

Summary:

Remove support for 'pixel' and 'pos' CSSOM prefixes

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

CSS

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, cdumez, commit-queue, darin, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hyatt, joepeck, jonlee, macpherson, menard, mkwst, sam, simon.fraser, syoichi, webkit-bug-importer

Priority:

Keywords:

BlinkMergeCandidate, InRadar, WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=218158

Bug Depends on:

218525

Bug Blocks:

Attachments:

Description	Flags
Merges the patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none

Ryosuke Niwa

Reported 2013-08-12 18:12:10 PDT

Consider merging https://chromium.googlesource.com/chromium/blink/+/7cb1d002fd79604c9e8d0bd810ba6f8f21ca78af These prefixes are: 1. Non-standard: the CSSOM standard doesn't mention them. 2. Broken: 'pixelWidth' should automagically convert from whatever unit the stylesheet specified into CSS pixels[1]. We're currently not doing that at all: if an element has a 'width' of 100em, pixelWidth is '100', which is probably wildly inaccurate. 3. Not covered by any tests ('fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html' is the only test mentioning these properties, and it only checks case-sensitivity: it doesn't validate behavior). This patch drops support completely. [1]: http://msdn.microsoft.com/en-us/library/ie/ms531135(v=vs.85).aspx

Attachments
Merges the patch (8.99 KB, patch) 2013-08-12 19:16 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch (12.33 KB, patch) 2020-10-23 13:43 PDT, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (13.13 KB, patch) 2020-10-23 13:53 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (16.06 KB, patch) 2020-10-24 10:55 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (23.40 KB, patch) 2021-02-26 16:54 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (12.60 KB, patch) 2021-02-26 16:57 PST, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (12.64 KB, patch) 2021-02-26 18:32 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (12.75 KB, patch) 2021-02-26 18:34 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (12.75 KB, patch) 2021-02-27 09:50 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-08-12 19:16:50 PDT

Created attachment 208584 [details] Merges the patch

Simon Fraser (smfr)

Comment 2 2013-08-12 20:36:22 PDT

Hmm, would be nice to know if these are used in the wild.

Ryosuke Niwa

Comment 3 2013-08-12 20:42:12 PDT

(In reply to comment #2) > Hmm, would be nice to know if these are used in the wild. Indeed.

Ryosuke Niwa

Comment 4 2013-08-12 20:44:45 PDT

Here's blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/pixel$20pos/blink-dev/JS4nH_d1YkA/xd99lydDTfcJ We might want to discuss this on webkit-dev.

Joseph Pecoraro

Comment 5 2015-11-12 15:29:17 PST

Comment on attachment 208584 [details] Merges the patch I think this is a great idea. I just tested and both Firefox / Chrome no longer support this, so it doesn't seem like too controversial a change. Clearing flags to rebaseline.

Sam Weinig

Comment 6 2020-10-23 13:43:35 PDT

Created attachment 412209 [details] Patch

Sam Weinig

Comment 7 2020-10-23 13:53:19 PDT

Created attachment 412210 [details] Patch

Sam Weinig

Comment 8 2020-10-24 10:55:10 PDT

Created attachment 412241 [details] Patch

EWS

Comment 9 2020-10-25 09:34:51 PDT

Committed r268957: <https://trac.webkit.org/changeset/268957> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412241 [details].