Bug 119710

Summary: Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll()
Product: WebKit Reporter: Seokju Kwon <seokju>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Seokju Kwon 2013-08-12 17:53:40 PDT 
Remove unused parameter warning.
WebKit/Source/WebCore/rendering/RenderObject.cpp:127:13: warning: unused parameter ‘frameView’ [-Wunused-parameter]
Comment 1 Seokju Kwon 2013-08-12 18:05:38 PDT 
Created attachment 208579 [details]
Patch
Comment 2 Darin Adler 2013-08-12 18:09:16 PDT 
Comment on attachment 208579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review

> Source/WebCore/rendering/RenderObject.cpp:129
> -#if !ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)
> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT))

That’s the same as just change && to ||, why make it so complicated?
Comment 3 Darin Adler 2013-08-12 18:10:32 PDT 
Comment on attachment 208579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review

>> Source/WebCore/rendering/RenderObject.cpp:129
>> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT))
> 
> That’s the same as just change && to ||, why make it so complicated?

In other words, this is:

    #if !A || (A && !B)

Which is the same as:

    #if !A || !B
Comment 4 Seokju Kwon 2013-08-12 18:16:29 PDT 
(In reply to comment #3)
> (From update of attachment 208579 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review
> 
> >> Source/WebCore/rendering/RenderObject.cpp:129
> >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT))
> > 
> > That’s the same as just change && to ||, why make it so complicated?
> 
> In other words, this is:
> 
>     #if !A || (A && !B)
> 
> Which is the same as:
> 
>     #if !A || !B

Just check it explicitly. You're right.
It could be so complicated. Thanks.
Comment 5 Seokju Kwon 2013-08-12 18:16:41 PDT 
Created attachment 208580 [details]
Patch
Comment 6 Seokju Kwon 2013-08-12 18:49:26 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 208579 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review
> > 
> > >> Source/WebCore/rendering/RenderObject.cpp:129
> > >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT))
> > > 
> > > That’s the same as just change && to ||, why make it so complicated?
> > 
> > In other words, this is:
> > 
> >     #if !A || (A && !B)
> > 
> > Which is the same as:
> > 
> >     #if !A || !B
> 
> Just check it explicitly. You're right.
> It could be so complicated. Thanks.

Fixed it.
Comment 7 WebKit Commit Bot 2013-08-12 22:46:20 PDT 
Comment on attachment 208580 [details]
Patch

Clearing flags on attachment: 208580

Committed r153974: <http://trac.webkit.org/changeset/153974>
Comment 8 WebKit Commit Bot 2013-08-12 22:46:22 PDT 
All reviewed patches have been landed.  Closing bug.