Bug 119702

Summary: Stop making unnecessary copy of CodeBlock Identifier Vector
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch msaboff: review+

Oliver Hunt
Reported 2013-08-12 15:29:52 PDT
Stop making unnecessary copy of CodeBlock Identifier Vector
Attachments
Patch (26.36 KB, patch)
2013-08-12 15:32 PDT, Oliver Hunt 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-08-12 15:32:48 PDT
Created attachment 208567 [details] Patch
Oliver Hunt
Comment 2 2013-08-12 15:38:06 PDT
Committed r153962: <http://trac.webkit.org/changeset/153962>
Geoffrey Garen
Comment 3 2013-08-12 15:48:07 PDT
Comment on attachment 208567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208567&action=review > Source/JavaScriptCore/bytecode/CodeBlock.h:1090 > + Vector<Identifier> m_additionalIdentifiers; Can we call this m_dfgIdentifiers? Would be even better to put this in rare data, since most code blocks are not DFG compiled.
Note You need to log in before you can comment on or make changes to this bug.