Bug 119702

Summary:

Stop making unnecessary copy of CodeBlock Identifier Vector

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	msaboff: review+

Description Oliver Hunt 2013-08-12 15:29:52 PDT

Stop making unnecessary copy of CodeBlock Identifier Vector

Comment 1 Oliver Hunt 2013-08-12 15:32:48 PDT

Created attachment 208567 [details]
Patch

Comment 2 Oliver Hunt 2013-08-12 15:38:06 PDT

Committed r153962: <http://trac.webkit.org/changeset/153962>

Comment 3 Geoffrey Garen 2013-08-12 15:48:07 PDT

Comment on attachment 208567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208567&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.h:1090
> +    Vector<Identifier> m_additionalIdentifiers;

Can we call this m_dfgIdentifiers? Would be even better to put this in rare data, since most code blocks are not DFG compiled.