Bug 119700

Summary:

Use const AtomicStringImpl* in DocumentOrderedMap

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, cmarcelo, commit-queue, esprehn+autocc, ggaren, kangil.han, kling, koivisto, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

119701

Attachments:

Description	Flags
Cleanup	benjamin: review+

Description Ryosuke Niwa 2013-08-12 14:37:13 PDT

Use AtomicStringImpl* in DocumentOrderedMap

Comment 1 Ryosuke Niwa 2013-08-12 14:41:52 PDT

Created attachment 208565 [details]
Cleanup

Comment 2 Benjamin Poulain 2013-08-12 14:46:58 PDT

Comment on attachment 208565 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=208565&action=review

> Source/WebCore/ChangeLog:9
> +        Use const AtomicStringImpl* in DocumentOrderedMap. It caught at least one bug that HTMLNameCollection'
> +        subclasses' nodeMatches were taking const AtomicString& instead of AtomicStringImpl*.

I think you should detail this a little more.

Comment 3 Ryosuke Niwa 2013-08-12 14:48:50 PDT

Committed r153959: <http://trac.webkit.org/changeset/153959>