Bug 119700

Summary: Use const AtomicStringImpl* in DocumentOrderedMap
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cmarcelo, commit-queue, esprehn+autocc, ggaren, kangil.han, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 119701    
Attachments:
Description Flags
Cleanup benjamin: review+

Ryosuke Niwa
Reported 2013-08-12 14:37:13 PDT
Use AtomicStringImpl* in DocumentOrderedMap
Attachments
Cleanup (15.36 KB, patch)
2013-08-12 14:41 PDT, Ryosuke Niwa 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-08-12 14:41:52 PDT
Created attachment 208565 [details] Cleanup
Benjamin Poulain
Comment 2 2013-08-12 14:46:58 PDT
Comment on attachment 208565 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=208565&action=review > Source/WebCore/ChangeLog:9 > + Use const AtomicStringImpl* in DocumentOrderedMap. It caught at least one bug that HTMLNameCollection' > + subclasses' nodeMatches were taking const AtomicString& instead of AtomicStringImpl*. I think you should detail this a little more.
Ryosuke Niwa
Comment 3 2013-08-12 14:48:50 PDT
Committed r153959: <http://trac.webkit.org/changeset/153959>
Note You need to log in before you can comment on or make changes to this bug.