Bug 11968

Summary: BidiContext's m_basicDir is redundant
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Remove m_basicDir ggaren: review+

mitz
Reported 2006-12-25 08:13:12 PST
BidiContext's m_basicDir is redundant. The only place it's used it can be replaced with style()->direction().
Attachments
Remove m_basicDir (2.65 KB, patch)
2006-12-26 09:42 PST, mitz 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-12-26 09:42:41 PST
Created attachment 12035 [details] Remove m_basicDir No layout test regressions.
Geoffrey Garen
Comment 2 2006-12-26 10:32:05 PST
Comment on attachment 12035 [details] Remove m_basicDir r=me
Sam Weinig
Comment 3 2006-12-27 13:34:19 PST
Landed in r18439.
Note You need to log in before you can comment on or make changes to this bug.