Bug 119679

Summary:

Remove the cast-align warnings for ARM

Product:

WebKit

Reporter:

Víctor M. Jáquez L. <vjaquez>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, commit-queue, esprehn+autocc, glenn, kling, koivisto, macpherson, menard, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
list of cast align warnings	none
Patch	none
Patch	none

Víctor M. Jáquez L.

Reported 2013-08-12 04:08:32 PDT

Compiling for armhf, gcc (4.7.3) reports ~830 cast-align warnings. These warnings might be silenced using reinterpret_cast_ptr<>.

Attachments
list of cast align warnings (18.60 KB, application/x-gzip) 2013-08-12 04:09 PDT, Víctor M. Jáquez L.	no flags	Details
Patch (2.15 KB, patch) 2013-08-19 07:27 PDT, Víctor M. Jáquez L.	no flags	Details Formatted Diff Diff
Patch (2.12 KB, patch) 2013-08-19 09:44 PDT, Víctor M. Jáquez L.	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Víctor M. Jáquez L.

Comment 1 2013-08-12 04:09:22 PDT

Created attachment 208529 [details] list of cast align warnings

Víctor M. Jáquez L.

Comment 2 2013-08-19 07:27:22 PDT

Created attachment 209084 [details] Patch

WebKit Commit Bot

Comment 3 2013-08-19 09:01:47 PDT

Comment on attachment 209084 [details] Patch Rejecting attachment 209084 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 209084, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/1515267

Víctor M. Jáquez L.

Comment 4 2013-08-19 09:44:41 PDT

Created attachment 209094 [details] Patch

Víctor M. Jáquez L.

Comment 5 2013-08-19 09:45:39 PDT

Oops, sorry for the OOPS in the ChangeLog :(

WebKit Commit Bot

Comment 6 2013-08-19 10:50:01 PDT

Comment on attachment 209094 [details] Patch Clearing flags on attachment: 209094 Committed r154285: <http://trac.webkit.org/changeset/154285>

WebKit Commit Bot

Comment 7 2013-08-19 10:50:03 PDT

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 8 2015-10-06 06:02:46 PDT

*** Bug 118246 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.